Language options #3123
Merged
Language options #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichDom2185
reviewed
Apr 17, 2025
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
Just the one comment, thanks!
| 2?: string; // For mission control | ||
| }>; | ||
| moduleParams?: any; | ||
| languageOptions?: any; |
Member
There was a problem hiding this comment.
Double check, can we avoid any here?
Contributor
Author
There was a problem hiding this comment.
Have fixed this on the latest push. Thanks!
Pull Request Test Coverage Report for Build 19103251689Details
💛 - Coveralls |
RichDom2185
approved these changes
Nov 5, 2025
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
LGTM, thanks! Let's test this out on .org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's objective to add language options support to Source Academy. The use case for now is to allow instructors to configure the strictness of Source Typed variants.
This PR enables the assessments workspace to correctly fetch and process the new
Libraryschema from the backend.Please first merge the PR on js-slang before merging this one.